Add xdr command to root #1307
Merged
Add xdr command to root #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnando
approved these changes
May 1, 2024
This reverts commit 192c899.
RPC tests are a bit flakey, it needs investigation separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add xdr command to root of cli command structure.
Why
It is currently under the lab, but at some point in the past we had commented about moving it to the root because really the majority of the CLI is "lab-like" commands and so having some commands under a lab subcommand makes little sense. XDR is also so prevalent that functionality to use it should be accessible. As a first step this PR adds it to the root. A follow up PR can remove it from the lab command.