Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reupload of wasm if extension is v0 #1309

Merged
merged 4 commits into from
May 2, 2024

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented May 1, 2024

What

Resolves #1295

@sisuresh
Copy link
Contributor Author

sisuresh commented May 1, 2024

@fnando The error here in RPC Tests is the same one that you ran into. How did you fix this?

@leighmcculloch
Copy link
Member

That looks like the flakey test.'

@sisuresh
Copy link
Contributor Author

sisuresh commented May 2, 2024

That looks like the flakey test.'

Interesting... do we know what could cause the flakiness here? Is the ledger state changing after preflight or something?

Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@sisuresh sisuresh marked this pull request as ready for review May 2, 2024 01:32
@leighmcculloch leighmcculloch enabled auto-merge (squash) May 2, 2024 11:01
@leighmcculloch leighmcculloch merged commit 6253b7a into stellar:main May 2, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow re-upload of a contract ContractCodeEntry is missing ContractCodeCostInputs
2 participants