Fix/stellar asset bindings #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
May 17, 2024
willemneal
reviewed
May 17, 2024
willemneal
reviewed
May 17, 2024
willemneal
approved these changes
May 17, 2024
willemneal
force-pushed
the
FIX/StellarAssetBindings
branch
from
6d5a5a7
to
7051f3b
Compare
BlaineHeffron
force-pushed
the
FIX/StellarAssetBindings
branch
from
6b8356f
to
859ef53
Compare
|
@elizabethengelman Any ideas on the failing emulator tests? |
willemneal
reviewed
May 28, 2024
willemneal
reviewed
May 28, 2024
willemneal
approved these changes
May 28, 2024
BlaineHeffron
force-pushed
the
FIX/StellarAssetBindings
branch
from
8fb73a9
to
0d4b52e
Compare
It looks like the emulator tests are passing now, but definitely something we should keep an eye on in case they are flakey. |
remove unnecessary public modifier Co-authored-by: Willem Wyndham <willem@wyndham.tech>
prevent cloning Co-authored-by: Willem Wyndham <willem@wyndham.tech>
willemneal
force-pushed
the
FIX/StellarAssetBindings
branch
from
0d4b52e
to
393e6e4
Compare
willemneal
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bindings command can now generate for a StellarAsset type contract. Fixes #1312
Logic for checking if its a StellarAsset was extracted from
invoke.rstoget_spec.rsused by bothinvokeandbindings.Why
Bindings were failing when trying to retrieve the wasm for a StellarAsset type from the contract Id.
Known limitations
none