Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the contract-ids dir #1339

Merged
merged 3 commits into from
May 29, 2024
Merged

Remove the contract-ids dir #1339

merged 3 commits into from
May 29, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented May 27, 2024

What

Remove the contract-ids directory from the .soroban directory prefilled in initialised contracts.

Why

The contract-ids directory isn't used in examples, and isn't a pattern being encouraged since there are plans to add aliases.

cc @elizabethengelman

Known limitations

N/A

Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@willemneal willemneal enabled auto-merge (squash) May 29, 2024 15:15
@willemneal willemneal merged commit c3db75a into main May 29, 2024
20 checks passed
@willemneal willemneal deleted the remove-contract-ids branch May 29, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants