Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alias help. #1419

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Update alias help. #1419

merged 2 commits into from
Jun 29, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Jun 28, 2024

What

The original --alias implementation had --force to overwrite existing contract id aliases, but @leighmcculloch suggested that it'd be better to always use the latest id. Now, @willemneal created a ticket to add that back. Until we come to a decision, let's make the flag help explicit.

Why

So people can know that --alias will always store the latest contract id without asking for confirmation.

Known limitations

N/A

Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah to me we should make the redeploy easier, but devs are currently required to include a redeploy method. But once we have the snapshot stuff we can copy over the state to the newly deployed contract and all should be okay.

@willemneal willemneal enabled auto-merge (squash) June 28, 2024 17:52
@willemneal willemneal merged commit d8bf2b0 into main Jun 29, 2024
25 checks passed
@willemneal willemneal deleted the update-alias-help branch June 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants