Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore vscode settings #1444

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented Jul 11, 2024

This is for developing as it will allow integration tests (hidden behind the feature flag) to be indexed by RA.

It also ignores all future edits to the file.

This is for developing as it will allow integration tests (hidden behind the feature flag) to be indexed by RA
@willemneal willemneal requested review from fnando and chadoh July 11, 2024 16:32
Copy link
Member

@fnando fnando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add editor configs to the repo? I'm always on the fence about this. Maybe we should add the .vscode to .gitignore instead, then you won't be bugged about having a new file.

@willemneal
Copy link
Member Author

I wager most Devs use VSCode and if they are going to work on tests this is a must. Also for me if I move to a new computer I prefer to have this already there. It's a small file that doesn't affect other editors. But if there are strong opinions I'm fine having to copy and paste this to each time I set up.

@willemneal
Copy link
Member Author

On second thought devs might want to edit it so I just did git rm --cached and added it to the .gitignore so that future updates will be ignored.

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fnando fnando changed the title chore: add it feature to rust-analyzer in vscode chore: ignore vscode settings Jul 11, 2024
@willemneal willemneal merged commit 83c90b7 into stellar:main Jul 11, 2024
24 checks passed
@leighmcculloch
Copy link
Member

I highly recommend the Rust Feature Toggler extension if you aren't using it. It provides a status bar UI for toggling whether a feature is enabled or not in a rust project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants