Feature: Adds logging for DiagnosticEvents that are emitted during simulation #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlaineHeffron Is this something you're still contributing? |
Yes, it depends on stellar/rs-stellar-rpc-client#8 first though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
DiagnosticEventsemitted during a simulation are returned after this PR is merged: stellar/rs-stellar-rpc-client#8The CLI will now log these and print out the JSON string of the event.
Why
It is nice to have a human readable string in addition to the XDR of the event. Resolves #1447
Known limitations
N/A