-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contract info
#1532
Add contract info
#1532
Conversation
- Add basic command structure
- Some places are TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I left some comments inline.
### What Expose rust code gen of contracts without the file import. ### Why The code gen function for rust code generates the interface and types as well as an import of the wasm binary. The CLI uses this function and wants to output the generated code without the wasm binary. Related to: - stellar/stellar-cli#1532 (comment)
…tract-info # Conflicts: # Cargo.lock
Can we make the json output be prettified? |
@fnando pretty json is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some code being deleted that is a breaking change, and one other ask, otherwise looks good.
What
Adds
contract info
command following #1506 spec.Available flags (for all subcommands)
Shared output flag for meta/env-meta:
Output flag for interface:
Examples of running the command:
stellar contract info env-meta
stellar contract info meta
stellar contract info interface
Why
See #1506
Known limitations
Network configuration is mandatory, even when fetching from local. This is due to group can't be marked as optional with clap's derive API. We can fix that in the future, potentially using more flexible builder API instead.