-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook documentation #1541
Cookbook documentation #1541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the cookbook is hand written, it might be best committed to the stellar-docs repo. The main reason we keep the full help markdown here is it is generated from code, but for the cookbook it is not generated. And all other hand written documentation simply lives in stellar-docs.
If we can write a test that executes the cookbook top-to-bottom to confirm the commands are valid, that's definitely a reason to keep it here though. Is that something we're planning to do as part of this change? |
I agree regarding the manually written stuff. Originally I had just added these entries to https://developers.stellar.org/docs/build/guides/cli but Jane wanted to have a document that lives on the the CLI github. See discussion here - stellar/stellar-docs#840 I think that adding a test that runs through the commands is a great idea. My question is, it seems like the cli guide has quite a bit of "cookbook" style documentation already; should we add all of those to this document as well so that they all get tested? We could even auto generate those entries from this document. |
Agreed, the existing guides are already a cookbook, and these don't need to be two different efforts. +1 to combining them, hosting them all here so we can run tests on them. It would be good if we could keep them as separate files and not bundle them all into a single file. @janewang wdyt? |
It makes sense to move the guides to the CLI repo to run tests. Then copy over to the final guides to the dev docs for visibility. |
Blocked by this bug #1557 |
Hi @BlaineHeffron, the issue that is blocking this PR is closed. |
What
Adds a
Cookbook.md
file which gets copied over bystellar-docs
for documentation on commonstellar
use cases.Why
Easy for
stellar-cli
maintainers to add "cookbook" entries from thestellar-cli
repo.Close #1438
Known limitations
N/A