Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook documentation #1541

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Cookbook documentation #1541

merged 14 commits into from
Sep 9, 2024

Conversation

BlaineHeffron
Copy link
Contributor

@BlaineHeffron BlaineHeffron commented Aug 12, 2024

What

Adds a Cookbook.md file which gets copied over by stellar-docs for documentation on common stellar use cases.

Why

Easy for stellar-cli maintainers to add "cookbook" entries from the stellar-cli repo.

Close #1438

Known limitations

N/A

@BlaineHeffron BlaineHeffron marked this pull request as ready for review August 12, 2024 16:35
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the cookbook is hand written, it might be best committed to the stellar-docs repo. The main reason we keep the full help markdown here is it is generated from code, but for the cookbook it is not generated. And all other hand written documentation simply lives in stellar-docs.

@leighmcculloch
Copy link
Member

If we can write a test that executes the cookbook top-to-bottom to confirm the commands are valid, that's definitely a reason to keep it here though. Is that something we're planning to do as part of this change?

@BlaineHeffron
Copy link
Contributor Author

I agree regarding the manually written stuff. Originally I had just added these entries to https://developers.stellar.org/docs/build/guides/cli but Jane wanted to have a document that lives on the the CLI github. See discussion here - stellar/stellar-docs#840

I think that adding a test that runs through the commands is a great idea. My question is, it seems like the cli guide has quite a bit of "cookbook" style documentation already; should we add all of those to this document as well so that they all get tested? We could even auto generate those entries from this document.

@leighmcculloch
Copy link
Member

I think that adding a test that runs through the commands is a great idea. My question is, it seems like the cli guide has quite a bit of "cookbook" style documentation already; should we add all of those to this document as well so that they all get tested? We could even auto generate those entries from this document.

Agreed, the existing guides are already a cookbook, and these don't need to be two different efforts. +1 to combining them, hosting them all here so we can run tests on them. It would be good if we could keep them as separate files and not bundle them all into a single file.

@janewang wdyt?

@janewang
Copy link
Contributor

It makes sense to move the guides to the CLI repo to run tests. Then copy over to the final guides to the dev docs for visibility.

@janewang
Copy link
Contributor

Blocked by this bug #1557

@janewang
Copy link
Contributor

janewang commented Sep 3, 2024

Hi @BlaineHeffron, the issue that is blocking this PR is closed.

@BlaineHeffron BlaineHeffron merged commit 50e0f19 into stellar:main Sep 9, 2024
26 checks passed
@BlaineHeffron BlaineHeffron deleted the docs/cookbook branch September 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhance CLI cookbook documentation by incorporating specific arguments for command lines
4 participants