Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): use String, not Symbol, in hello_world #1577

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Aug 29, 2024

What

Updates hello_world to match the version that has been in
soroban-examples since stellar/soroban-examples#314

Why

because Symbol is so annoying!!

Known limitations

[TODO or N/A]

Updates `hello_world` to match the version that has been in
`soroban-examples` since stellar/soroban-examples#314
@willemneal willemneal enabled auto-merge (squash) August 30, 2024 05:51
@willemneal willemneal merged commit d11c7e0 into main Aug 30, 2024
25 checks passed
@willemneal willemneal deleted the fix/embedded-hello-world-strings branch August 30, 2024 12:21
chadoh added a commit that referenced this pull request Aug 30, 2024
forgot to run `make build-snapshot` as part of #1577

if you run `make build-snapshot` on `main` right now, you end up with
these artifact changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants