-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add meta on build #1684
Feat/add meta on build #1684
Conversation
Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
26dab76
to
36e9d34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, three minor tweaks otherwise 👍🏻.
Have you tried deploying a contract built with the additional meta option?
e819746
to
0a1d79e
Compare
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
60b7ef9
to
908ee6d
Compare
cmd/crates/soroban-test/tests/fixtures/workspace/contracts/add/src/lib.rs
Show resolved
Hide resolved
561d985
to
1b188a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
This could impact others, so we should do an announcement 📣 in Discord so folks know that it's appending a second custom section with the same name. @elizabethengelman can you do that?
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
6c3ab45
to
3939e15
Compare
@leighmcculloch sure thing! does posting in #announcements make sense, or is there another channel? |
It's a bit low level and won't be important for contract developers likely to know, so in the |
What
Closes #1605
Why
Allows users to add additional meta to their contract wasm on build.
Known limitations
n/a