Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add meta on build #1684

Merged
merged 24 commits into from
Oct 30, 2024
Merged

Feat/add meta on build #1684

merged 24 commits into from
Oct 30, 2024

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Oct 23, 2024

What

Closes #1605

Why

Allows users to add additional meta to their contract wasm on build.

Known limitations

n/a

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, three minor tweaks otherwise 👍🏻.

Have you tried deploying a contract built with the additional meta option?

elizabethengelman and others added 3 commits October 28, 2024 10:00
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@elizabethengelman elizabethengelman marked this pull request as ready for review October 28, 2024 14:04
@elizabethengelman elizabethengelman requested a review from a team as a code owner October 28, 2024 14:04
@elizabethengelman
Copy link
Contributor Author

elizabethengelman commented Oct 28, 2024

Have you tried deploying a contract built with the additional meta option?

I have not yet, but will do that shortly! Great idea!

update:
just tested this on testnet, and verified that that meta included the new meta values added on build:
Screenshot 2024-10-28 at 10 45 36 AM
Screenshot 2024-10-28 at 10 45 52 AM
Screenshot 2024-10-28 at 10 45 58 AM

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

This could impact others, so we should do an announcement 📣 in Discord so folks know that it's appending a second custom section with the same name. @elizabethengelman can you do that?

Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@elizabethengelman
Copy link
Contributor Author

This could impact others, so we should do an announcement 📣 in Discord so folks know that it's appending a second custom section with the same name. @elizabethengelman can you do that?

@leighmcculloch sure thing! does posting in #announcements make sense, or is there another channel?

@leighmcculloch
Copy link
Member

#announcements make sense, or is there another channel?

It's a bit low level and won't be important for contract developers likely to know, so in the soroban-itself channel, starting a thread, and then we can mention folks we expect will be of interest. And anyone else can see thet hread and hopefully tag others if they know of anyone.

@elizabethengelman elizabethengelman merged commit 1fb8559 into main Oct 30, 2024
26 checks passed
@elizabethengelman elizabethengelman deleted the feat/add-meta-on-build branch October 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add meta during stellar contract build
4 participants