fix: update stellar dependencies #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to update soroban client to a released version. Otherwise just updating to newest release candidates
leighmcculloch
approved these changes
Nov 2, 2024
Comment on lines
4731
to
+4735
| "serde_json", | ||
| "soroban-env-guest 22.0.0-rc.1.1", | ||
| "soroban-env-host 22.0.0-rc.1.1", | ||
| "soroban-ledger-snapshot 22.0.0-rc.1.1", | ||
| "soroban-sdk-macros 22.0.0-rc.1.1", | ||
| "soroban-env-guest 22.0.0-rc.3", | ||
| "soroban-env-host 22.0.0-rc.3", | ||
| "soroban-ledger-snapshot 22.0.0-rc.3", | ||
| "soroban-sdk-macros 22.0.0-rc.3", |
There was a problem hiding this comment.
@willemneal The fact versions are included for these soroban deps, means that somehow we're pulling in multiple versions of each. We should be only using one version of these across the whole repo, so some investigation is needed to figure out what is importing the old version and remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to update soroban client to a released version. Otherwise just updating to newest release candidates