Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Add admin endpoint including pprof debug endpoints #573

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

2opremio
Copy link
Contributor

What

Add admin http endpoint containing pprof debug endpoints

It adds an --admin-endpoint flag (matching the normal --endpoint flag), which indicates where to listen.

For instance, when providing --admin-endpoint http://localhost:9000 the endpoints like the following will be exposed:

http://localhost:9000/debug/pprof/
http://localhost:9000/debug/pprof/cmdline
http://localhost:9000/debug/pprof/profile
http://localhost:9000/debug/pprof/symbol
http://localhost:9000/debug/pprof/trace
...

Depends on #566

Why

Closes #498 and paces the way for #496 which also needs an admin base endpoint

Known limitations

[TODO or N/A]

@2opremio 2opremio requested review from tamirms and paulbellamy April 10, 2023 16:28
@2opremio 2opremio force-pushed the add-admin-pprof-port branch from 3305dbf to 60c6f68 Compare April 10, 2023 16:29
@2opremio 2opremio force-pushed the add-admin-pprof-port branch from b70b060 to 9b4ce86 Compare April 11, 2023 10:15
@2opremio
Copy link
Contributor Author

@tsachiherman PTAL, can't merge without your confirmation.

@2opremio 2opremio enabled auto-merge (squash) April 11, 2023 14:57
@tsachiherman
Copy link
Contributor

@tsachiherman PTAL, can't merge without your confirmation.

I blocked this one only for the nil issue I pointed out ( and you fixed ).

@2opremio 2opremio merged commit 6c91383 into stellar:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soroban-rpc: Add configurable pprof support
4 participants