Infer 80/443 ports for http/https rpc-url #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Apr 10, 2023
leighmcculloch
requested review from
tsachiherman
and removed request for
paulbellamy
tomerweller
approved these changes
Apr 11, 2023
paulbellamy
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Infer 80/443 ports for http/https rpc-url
Why
When not including a port in the rpc-url an error message is displayed because jsonrpsee requires the port to be specified (paritytech/jsonrpsee#1048). This is not particularly ergonomic. Although it has no otherwise functional impact and causes no other problem. Folks are just not accustomed to thinking about ports for http and https.