-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: Add /metrics endpoint #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tamir, I don't believe that the PrometheusRegistry should be part of the local configuration.
( unless you can convince me otherwise ).
I think that it should be a member of the daemon.
The local config is for entries that we would load from a configuration file. I don't believe the registry is part of that..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a unit test to confirm that this PR work ?
@tsachiherman can you take another look? I think I've addressed your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tamir, my intent in asking for a unit test was to have a http-client unit test that would verify that the metrics endpoint works as expected.
I don't have any reason to believe that it wouldn't, and I don't want to block you from merging this one in - but I do want to have ( eventually ) a concrete unit test to cover all the http endpoints.
@tsachiherman could you take another look? I believe I've addressed your feedback. |
What
Add
/metrics
prometheus endpoint with the following set of metrics:DB (similar to horizon)
General
Logging
Why
#496
This PR does not provide all the metrics specified in the issue above. The remaining metrics be included in separate upcoming PRs.
Known limitations
[N/A]