feat(CLI): config identity fund to fund accounts on networks
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing on some platforms. For aarch64 it seems openssl doesn't build (maybe there is a missing dependency?) |
willemneal
force-pushed
the
feat/friendbot
branch
3 times, most recently
from
16ea653
to
e7be58a
Compare
|
I'm going to disable windows for this command to allow the CI to be happy. Here is an open issue to solve this in the future: |
I suspect that you'll need to add this platform-limit also in the cargo.toml |
willemneal
force-pushed
the
feat/friendbot
branch
from
8cd822b
to
152e21a
Compare
Also use `network` on `config identity generate`
willemneal
force-pushed
the
feat/friendbot
branch
from
152e21a
to
946b348
Compare
tsachiherman
approved these changes
Aug 10, 2023
kalepail
pushed a commit
to kalepail/soroban-tools
that referenced
this pull request
Aug 10, 2023
…ar#828) * feat: fund command * feat: move `config identity` Also use `network` on `config identity generate` * fix: allow for https and provide better errors * fix: docs and fmt * fix: get url from rpc and add openssl * fix: docs * fix: skip https on windows for now * fix: prevent windows in cargo.toml
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Aug 10, 2023
…ar#828) * feat: fund command * feat: move `config identity` Also use `network` on `config identity generate` * fix: allow for https and provide better errors * fix: docs and fmt * fix: get url from rpc and add openssl * fix: docs * fix: skip https on windows for now * fix: prevent windows in cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
And new subcommand for funding accounts. And allow funding accounts when using
soroban config identity generateWhy
Remove the dependency on using tools like curl.
Known limitations
[TODO or N/A]