Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Add two new output types for contract inspect #829

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

willemneal
Copy link
Member

What

Add --output with options docs (default), xdr-base64, and xdr-base64-array

Why

It can be useful to get the raw values and a json array makes it easier to parse in JS.

Known limitations

[TODO or N/A]

Now it can also output base64 xdr of the spec and an array of entries each encoded as base64  xdr.
Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great for consistency (and usefulness) to add --output xdr-base64 to other commands with a --output flag, like contract read, events, (and eventually invoke?)

@willemneal willemneal merged commit 26b923a into stellar:main Aug 4, 2023
willemneal added a commit to AhaLabs/stellar-cli that referenced this pull request Aug 9, 2023
* feat(CLI): add output type to contract inspect

Now it can also output base64 xdr of the spec and an array of entries each encoded as base64  xdr.

* fix: move array to spec definition

---------

Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
kalepail pushed a commit to kalepail/soroban-tools that referenced this pull request Aug 10, 2023
* feat(CLI): add output type to contract inspect

Now it can also output base64 xdr of the spec and an array of entries each encoded as base64  xdr.

* fix: move array to spec definition

---------

Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants