feat(CLI): Each generated contract method adds <contract-arg>-file-path #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
reviewed
Aug 3, 2023
willemneal
force-pushed
the
feat/arg_from_file
branch
from
fa943a5
to
5562d95
Compare
This allows passing file paths in place of arguments. Files are read as strings for all types except Bytes and BytesN where the file is read as raw bytes. The info about the new args is in the help doc header for each subcommand, otherwise the new args are hidden to not clog up the help documentation.
willemneal
force-pushed
the
feat/arg_from_file
branch
from
5562d95
to
8929fe5
Compare
paulbellamy
approved these changes
Aug 4, 2023
willemneal
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Aug 9, 2023
…th (stellar#833) * feat(CLI): Each generated contract method adds <contract-arg>-file-path This allows passing file paths in place of arguments. Files are read as strings for all types except Bytes and BytesN where the file is read as raw bytes. The info about the new args is in the help doc header for each subcommand, otherwise the new args are hidden to not clog up the help documentation. * fix: docs * feat: add conflicts_with to arg-file for normal arg --------- Co-authored-by: Paul Bellamy <paul@stellar.org>
kalepail
pushed a commit
to kalepail/soroban-tools
that referenced
this pull request
Aug 10, 2023
…th (stellar#833) * feat(CLI): Each generated contract method adds <contract-arg>-file-path This allows passing file paths in place of arguments. Files are read as strings for all types except Bytes and BytesN where the file is read as raw bytes. The info about the new args is in the help doc header for each subcommand, otherwise the new args are hidden to not clog up the help documentation. * fix: docs * feat: add conflicts_with to arg-file for normal arg --------- Co-authored-by: Paul Bellamy <paul@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This allows passing file paths in place of arguments. Files are read as strings for all types except Bytes and BytesN which are read as raw bytes.
The info about the new args is in the help doc header for each subcommand, otherwise the new args are hidden to not clog up the help documentation.
Why
This is particularly useful for passing bytes to contracts and avoids needed to convert them to hex as the current CLI requires.
Known limitations
[TODO or N/A]