Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI/bindings/ts): allow fetching contract from network #836

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

willemneal
Copy link
Member

What

Makes passing the wasm optional otherwise fetches the contract from the network.

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@willemneal
Copy link
Member Author

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Definitely some future refactoring opportunities, since this wasm_or_network_contract behavior is now replicated in a few places around the code base, but that can be done in the future.

@willemneal willemneal merged commit f25effe into stellar:main Aug 4, 2023
@chadoh chadoh deleted the feat/bindings_from_network branch August 4, 2023 14:41
willemneal added a commit to AhaLabs/stellar-cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants