Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Fix caching of GetLatestLedgerSequence #897

Merged
merged 1 commit into from
Aug 24, 2023
Merged

soroban-rpc: Fix caching of GetLatestLedgerSequence #897

merged 1 commit into from
Aug 24, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Aug 24, 2023 •
edited
Loading

🤦

This, by itself, doesn't really improve the preflight times though:

before:

goos: darwin
goarch: arm64
pkg: github.com/stellar/soroban-tools/cmd/soroban-rpc/internal/preflight
BenchmarkGetPreflight
BenchmarkGetPreflight/In-memory_storage
BenchmarkGetPreflight/In-memory_storage-12         	    7117	    166782 ns/op
BenchmarkGetPreflight/DB_storage
BenchmarkGetPreflight/DB_storage-12                	    4789	    227984 ns/op
BenchmarkGetPreflight/DB_storage,_restarting
BenchmarkGetPreflight/DB_storage,_restarting-12    	    5048	    227909 ns/op
BenchmarkGetPreflight/DB_storage,_no_cache
BenchmarkGetPreflight/DB_storage,_no_cache-12      	    2773	    425975 ns/op
PASS

after:

goos: darwin
goarch: arm64
pkg: github.com/stellar/soroban-tools/cmd/soroban-rpc/internal/preflight
BenchmarkGetPreflight
BenchmarkGetPreflight/In-memory_storage
BenchmarkGetPreflight/In-memory_storage-12         	    7110	    168305 ns/op
BenchmarkGetPreflight/DB_storage
BenchmarkGetPreflight/DB_storage-12                	    5136	    226321 ns/op
BenchmarkGetPreflight/DB_storage,_restarting
BenchmarkGetPreflight/DB_storage,_restarting-12    	    4845	    228496 ns/op
BenchmarkGetPreflight/DB_storage,_no_cache
BenchmarkGetPreflight/DB_storage,_no_cache-12      	    2647	    432240 ns/op
PASS

@2opremio 2opremio enabled auto-merge (squash) August 24, 2023 13:02
@2opremio 2opremio merged commit 06bcd7b into stellar:main Aug 24, 2023
19 of 20 checks passed
@2opremio 2opremio deleted the fix-caching-get-latest-ledger branch August 24, 2023 13:21
@2opremio 2opremio mentioned this pull request Aug 24, 2023
Merged
@dmore dmore mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

@paulbellamy paulbellamy paulbellamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2opremio @paulbellamy @tamirms