Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Limit request size to 10MB #898

Merged
merged 2 commits into from
Aug 24, 2023
Merged

soroban-rpc: Limit request size to 10MB #898

merged 2 commits into from
Aug 24, 2023

Conversation

2opremio
Copy link
Contributor

No description provided.

tsachiherman
tsachiherman approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think that this one is great. It would be even better to make the magic number ( 10M ) configurable.

@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Aug 24, 2023
@2opremio 2opremio enabled auto-merge (squash) August 24, 2023 17:31
@2opremio 2opremio merged commit 28478ef into stellar:main Aug 24, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

Assignees

@2opremio 2opremio

Labels
None yet
Projects
None yet
Milestone
Soroban Testnet Release
Development

Successfully merging this pull request may close these issues.
2 participants
@2opremio @tsachiherman