Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: getLedgerEntries: set maximum number of keys to query for #903

Merged
merged 5 commits into from
Aug 29, 2023
Merged

soroban-rpc: getLedgerEntries: set maximum number of keys to query for #903

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c88a9c
soroban-rpc: getLedgerEntries: set maximum number of keys to query for
2opremio Aug 25, 2023
aebba84
Merge branch 'main' into set-max-keys-getLedgerEntries
2opremio Aug 25, 2023
0cf4d21
Minor tweak
2opremio Aug 25, 2023
d1d443f
Merge branch 'main' into set-max-keys-getLedgerEntries
tsachiherman Aug 25, 2023
d703b4c
Merge branch 'main' into set-max-keys-getLedgerEntries
2opremio Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmd/soroban-rpc/internal/methods/get_ledger_entries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,19 @@ type GetLedgerEntriesResponse struct {
LatestLedger int64 `json:"latestLedger,string"`
}

const (
getLedgerEntriesMaxKeys = 200
)

// NewGetLedgerEntriesHandler returns a JSON RPC handler to retrieve the specified ledger entries from Stellar Core.
func NewGetLedgerEntriesHandler(logger *log.Entry, ledgerEntryReader db.LedgerEntryReader) jrpc2.Handler {
return handler.New(func(ctx context.Context, request GetLedgerEntriesRequest) (GetLedgerEntriesResponse, error) {
if len(request.Keys) > getLedgerEntriesMaxKeys {
return GetLedgerEntriesResponse{}, &jrpc2.Error{
Code: jrpc2.InvalidParams,
Message: fmt.Sprintf("key count (%d) exceeds maximum supported (%d)", len(request.Keys), getLedgerEntriesMaxKeys),
}
}
var ledgerKeys []xdr.LedgerKey
for i, requestKey := range request.Keys {
var ledgerKey xdr.LedgerKey
Expand Down