Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: set the exit code to 1 in case of an error #923

Merged
merged 2 commits into from
Sep 5, 2023
Merged

soroban-cli: set the exit code to 1 in case of an error #923

merged 2 commits into from
Sep 5, 2023

Conversation

tsachiherman
Copy link
Contributor

What

set the exit code to 1 in case of an error

Why

see #920

Known limitations

n/a

@tsachiherman tsachiherman self-assigned this Sep 4, 2023
@tsachiherman tsachiherman enabled auto-merge (squash) September 4, 2023 16:58
@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Sep 4, 2023
@tsachiherman tsachiherman merged commit 62aaa3d into main Sep 5, 2023
19 of 20 checks passed
@tsachiherman tsachiherman deleted the tsachi/cli-set-exit-code-on-error branch September 5, 2023 14:12
@tsachiherman tsachiherman mentioned this pull request Sep 5, 2023
Closed
@stellarsaur stellarsaur mentioned this pull request Nov 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

@tsachiherman tsachiherman

Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
Soroban Testnet Release
Development

Successfully merging this pull request may close these issues.
3 participants
@tsachiherman @leighmcculloch @willemneal