Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: return an error once contract read is unable to read any entry. #924

Merged
merged 6 commits into from
Sep 6, 2023
Merged

soroban-cli: return an error once contract read is unable to read any entry. #924

merged 6 commits into from
Sep 6, 2023

Conversation

tsachiherman
Copy link
Contributor

What

return an error once contract read is unable to read any entry.

Why

#920

Known limitations

n/a

@tsachiherman tsachiherman self-assigned this Sep 4, 2023
@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Sep 4, 2023
@tsachiherman tsachiherman marked this pull request as ready for review September 5, 2023 14:35
@tsachiherman tsachiherman linked an issue Sep 5, 2023 that may be closed by this pull request
soroban-cli: should return non-zero exit code when can't find data #920
Closed
@tsachiherman tsachiherman mentioned this pull request Sep 5, 2023
Closed
@tsachiherman tsachiherman enabled auto-merge (squash) September 5, 2023 16:12
@tsachiherman tsachiherman merged commit 89f5a23 into main Sep 6, 2023
@tsachiherman tsachiherman deleted the tsachi/cli-err-missing-ledger-keys branch September 6, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

@tsachiherman tsachiherman

Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
Soroban Testnet Release
Development

Successfully merging this pull request may close these issues.

soroban-cli: should return non-zero exit code when can't find data
2 participants
@tsachiherman @leighmcculloch