Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Background Eviction Mandatory #4503

Closed
SirTyson opened this issue Oct 10, 2024 · 0 comments · Fixed by #4575
Closed

Make Background Eviction Mandatory #4503

SirTyson opened this issue Oct 10, 2024 · 0 comments · Fixed by #4575
Assignees
Labels

Comments

@SirTyson
Copy link
Contributor

Starting in protocol 23, all validators need to run background eviction. There is no reason to run main thread eviction, so we should remove the flag and make background eviction required.

@SirTyson SirTyson added the bug label Oct 10, 2024
@SirTyson SirTyson self-assigned this Oct 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 18, 2024
# Description

Resolves #4503 and #4502

This change removes SQL support for all ledger state, except for the
offers table. It also enforces background eviction. In order to not
break Horizon, core will not crash if any of the old flags or config
settings are used. Instead it will print a warning and ignore the flags.
The flags should be removed in the next protocol release.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant