Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soroban upgrade transaction flow in modifySorobanNetworkConfig for tests #4640

Conversation

ThomasBrady
Copy link
Contributor

Description

Resolves #4605

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@ThomasBrady ThomasBrady force-pushed the fix-modify-soroban-network-config branch 2 times, most recently from 39cab6b to 0137581 Compare February 4, 2025 21:47
@ThomasBrady ThomasBrady requested a review from SirTyson February 4, 2025 21:49
@ThomasBrady ThomasBrady force-pushed the fix-modify-soroban-network-config branch 2 times, most recently from 12ea678 to a0d5937 Compare February 5, 2025 01:09
@SirTyson
Copy link
Contributor

SirTyson commented Feb 6, 2025

It looks like you accidentally deleted a lot of the meta files for tests. Make sure you run

stellar-core test [tx] --all-versions --rng-seed 12345 --record-test-tx-meta test-tx-meta-baseline-current

without the --enable-next-protocol-version-unsafe-for-production configure flag set and

stellar-core test [tx] --all-versions --rng-seed 12345 --record-test-tx-meta test-tx-meta-baseline-next

with --enable-next-protocol-version-unsafe-for-production set.

@ThomasBrady ThomasBrady force-pushed the fix-modify-soroban-network-config branch from a0d5937 to 509cae2 Compare February 6, 2025 06:13
@SirTyson SirTyson closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix modifySorobanNetworkConfig
2 participants