Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generic tests working #90

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Make generic tests working #90

merged 3 commits into from
Sep 13, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Sep 13, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

This PR does multiple things:

  • In my last PR, I added some tests to move scheduled queries to DBT tests. In the last moment, i updated tests to use staging table instead of source. I missed updating column names according to staging. This PR takes care of that
  • Update recency tests to error only in prod end since test env could be behind sometimes
  • Extract day using timestamp_trunc so as to get full day worth of data

Why

Explained above

Known limitations

[TODO or N/A]

@amishas157 amishas157 changed the title fix generic tests Make generic tests working Sep 13, 2024
@amishas157 amishas157 marked this pull request as ready for review September 13, 2024 15:08
@amishas157 amishas157 requested a review from a team as a code owner September 13, 2024 15:08
@amishas157 amishas157 merged commit da7cb2b into master Sep 13, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/fix-generic-tests branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants