Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit window to test eho reconciliation #92

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

amishas157
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

This PR shortens window to test re-conciliation of history_operations table and enriched_history_operation table.

history_operations is updated at a faster cadence (10 min) as compared to enriched_history_operations (30 min) . Therefore, to not be false alerted, the reconciliation test will be done for slightly older data - last 24 hours - last 1 hour.

Why

Explained above, we were getting false alarms from this singular test.

Known limitations

NA

@amishas157 amishas157 marked this pull request as ready for review September 16, 2024 11:02
@amishas157 amishas157 requested a review from a team as a code owner September 16, 2024 11:02
@amishas157 amishas157 force-pushed the patch/adjust-singular-tests branch from 2aac478 to 63a4ecb Compare September 16, 2024 11:03
@amishas157 amishas157 merged commit b62ec0a into master Sep 16, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/adjust-singular-tests branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants