Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recency tag and conditionally enable recency tests #97

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Sep 20, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the docs and README with the added features, breaking changes, new instructions on how to use the repository.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/* , feature/* or patch/* .

What

We want to run recency tests asynchronously to building DBT models. This PR:

  • Adds recency tag to all recency tests
  • Conditionally enable recency tests when target is ci (to find test coverage accurately) or when the env variable IS_RECENCY_AIRFLOW_TASK is set to true. This env var is set to true only in dbt_recency_test dag. See Add separate dag for recency tests stellar-etl-airflow#500

Why

The recency tests cause alert fatigue since they run with every model build. We do not need to run them so frequently.
Also, recency tests creates issue in backfilling old tasks if newest task is failing.

Known limitations

None

@amishas157 amishas157 force-pushed the patch/tag-recency-tests branch from 9e3a216 to 45aad24 Compare September 24, 2024 10:53
@amishas157 amishas157 changed the title Add recency tag Add recency tag and conditionally enable recency tests Sep 24, 2024
@amishas157 amishas157 marked this pull request as ready for review September 24, 2024 19:21
@amishas157 amishas157 requested a review from a team as a code owner September 24, 2024 19:21
@amishas157 amishas157 merged commit 3ee8ad5 into master Sep 25, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/tag-recency-tests branch November 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants