Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize "network" section content #686

Merged
merged 25 commits into from
Jun 20, 2024
Merged

Reorganize "network" section content #686

merged 25 commits into from
Jun 20, 2024

Conversation

ElliotFriend
Copy link
Contributor

@ElliotFriend ElliotFriend commented Jun 14, 2024 •
edited
Loading

We're going to:

  • move the core node docs out into their own navbar item
    • (don't forget to update the links in the core-node gh docs page)
  • move the disbursement/anchor platforms into the tools section
  • rename the navbar of what's left (horizon, rpc, hubble) to "Data"

@ElliotFriend ElliotFriend marked this pull request as draft June 14, 2024 18:27
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@ElliotFriend ElliotFriend marked this pull request as ready for review June 18, 2024 16:32
@ElliotFriend ElliotFriend requested a review from briwylde08 June 18, 2024 16:36
@briwylde08
add tools overview
e8ec3d3 
still missing links to SDP and AP cause I can't find them
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@briwylde08
Copy link
Contributor

This is looking so great! My only question is: Node Hardware Requirements seems kind of hidden and also contains Core Validator Node reqs even though it's in the Data section. Would this section make more sense somewhere else? Maybe Technical Reference (Reference)?

@ElliotFriend
Copy link
Contributor Author

@briwylde08 I was wondering about putting it in the "Reference" section, too! I talked with Justin about it today, and my plan at the moment is:

  • Leave it where it is, for now
  • Create some follow-up PRs later on to...
    1. isolate and (strategically) duplicate core node (for example) h/w requirements into the validators admin guide (and similar with horizon, rpc, etc.)
    2. add links to each relevant admin guide in the table so people can know exactly what they need to get started, and then get to the instructions quickly.
  • (perhaps? down the road?) move it somewhere else, depending on if/what feedback is given.

What do you think?

@briwylde08
Copy link
Contributor

Makes sense to me!

briwylde08
briwylde08 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@briwylde08 briwylde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr686.previews.kube001.services.stellar-ops.com

@ElliotFriend ElliotFriend merged commit a5af7b3 into main Jun 20, 2024
2 checks passed
@ElliotFriend ElliotFriend deleted the network-navbar-reorg branch June 20, 2024 16:13
This was referenced Jun 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briwylde08 briwylde08 briwylde08 approved these changes

@janewang janewang Awaiting requested review from janewang

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElliotFriend @stellar-jenkins @briwylde08