Added bucketListWindowSamplePeriod config setting #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MonsieurNicolas
approved these changes
Feb 1, 2024
SirTyson
added a commit
to SirTyson/stellar-xdr
that referenced
this pull request
Feb 1, 2024
MonsieurNicolas
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add the
bucketListWindowSamplePeriodState Archival network config parameter. While this is technically a protocol breaking XDR change, since this changes a single uint64 value to two uin32 values, the binary structure is identical. Since only core reads this particular value, and since the binary structure is identical so as to not have decoding errors between the two versions, down stream systems should not have to pick up this change to be compatible with protocol 20.