Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing enum value #38

Merged
merged 1 commit into from
Sep 23, 2022
Merged

add missing enum value #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Stellar-transaction.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,8 @@ struct LiquidityPoolWithdrawOp
enum HostFunction
{
HOST_FN_CALL = 0,
HOST_FN_CREATE_CONTRACT = 1
HOST_FN_CREATE_CONTRACT = 1,
HOST_FN_CREATE_CONTRACT_WITH_SOURCE = 2
Comment on lines +480 to +481
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is too late or inconvenient, don't worry about it, but if not, can we add an explicit _FROM_ED25519 to the existing one so there is no ambiguity about what it does? Am I interpreting it right that the existing one only does from ed25519?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also create a follow up issue for this later, it isn't important to do now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think it's easier to just do it now - #39.

};

struct InvokeHostFunctionOp
Expand Down