Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaScript references to use the latest stellar-sdk #81

Merged
merged 13 commits into from
Nov 2, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 25, 2023

Reference: stellar/stellar-cli#1048

Pending:

  • actually releasing the sdk
  • corresponding soroban-tools fixes
  • test runs to ensure it all works

@sreuland
Copy link
Contributor

I tried building and running the system-test image but noticed the soroban-rpc build step was failing due to tools Dockerfile needing to be udpated to 1.21 - https://github.com/stellar/soroban-tools/pull/1057/files

@sreuland
Copy link
Contributor

@Shaptic , I noticed further issues with latest quickstart image requiring different env variables to be defined during image. build, I've committed fix here

I'm running latest on the PR locally, first build system-test image with what I think is the latest version of core with stable/latest xdr, this is the git ref that was used for 19.14.1-1529.fcbbad4ce.focal , which mainline soroban-tools uses on rpc integration tests, and this builds rpc and cli with latest from main also:

make CORE_GIT_REF=https://github.com/stellar/stellar-core.git#fcbbad4ce7593d5b76c2b4cca883d51b2c702d73 JS_STELLAR_SDK_NPM_VERSION=11.0.0-beta.5 build

then I run the tests:

docker run --rm -it --name e2e_test stellar/system-test:dev --VerboseOutput true

but I'm seeing error in simulate tx web server handler in rpc server:

error: transaction simulation failed: host invocation failed
Caused by: HostError: Error(WasmVm, InvalidInput)

@Shaptic
Copy link
Contributor Author

Shaptic commented Oct 27, 2023

@sreuland shoot, okay. I'm not 100% sure about XDR compatibility (this thread has git refs), but the beta.5 is actually for current testnet rather than the current build 😕

I didn't realize we were updating the system tests to latest xdr also - I was just hoping to migrate them to use the stellar-sdk over soroban-client... In that case I need to push a PR that duplicates stellar/js-soroban-client#167 over to stellar-sdk, but I was hoping not to do that until we actually merged that PR... 😞

There's two options, I guess:

  • I can kick out a branch on Monday that ports the above PR to the stellar-sdk and use the gitref here or
  • we can keep using soroban-client and try to use the above branch instead to ensure e2e works and THEN port it to stellar-sdk later when that is released

@sreuland
Copy link
Contributor

@Shaptic , what's in this pr should still be related to just enabling stellar-sdk usage in system test for any set of soroban platform component versions. Sounds like my attempt to verify these changes which use js-stellar-sdk by building and running system-test with the mainline versions was incorrect state. I let defaults kick in on the build for latest mainline versions of cli/rpc and set core =fcbbad4ce7` and js=11.0.0-beta.5.

We just need to re-run system-test build from this PR with the correct/matched versions that will work with some version of js-stellar-sdk, should i build using the latest Preview 11 versions for core/rpc/cli and then what version of js-stellar-sdk works with the preview 11? currently js-soroban-client is ref'd for js in preview 11 only.

@Shaptic
Copy link
Contributor Author

Shaptic commented Oct 31, 2023

We just need to re-run system-test build from this PR with the correct/matched versions that will work with some version of js-stellar-sdk

@sreuland I think that's right, yeah: stellar-sdk@v11.0.0-beta.5 uses XDR that is compatible with the current testnet, so that plus the other versions from the Preview 11 doc should be correct. I opened stellar-deprecated/soroban-docs#634 to rectify this.

@sreuland
Copy link
Contributor

sreuland commented Nov 1, 2023

I think we'll need #83 to merge and pull that in here, as tests aren't able to get cli to install a contract due to that rc sdk usage on the soroban-examples.

@Shaptic Shaptic marked this pull request as ready for review November 2, 2023 21:13
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Nov 2, 2023
@Shaptic Shaptic requested a review from sreuland November 2, 2023 21:13
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid work!

@Shaptic Shaptic merged commit 99b73c4 into master Nov 2, 2023
3 checks passed
@Shaptic Shaptic deleted the js-rename branch November 2, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants