-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JavaScript references to use the latest stellar-sdk
#81
Conversation
I tried building and running the system-test image but noticed the soroban-rpc build step was failing due to tools Dockerfile needing to be udpated to 1.21 - https://github.com/stellar/soroban-tools/pull/1057/files |
@Shaptic , I noticed further issues with latest quickstart image requiring different env variables to be defined during image. build, I've committed fix here I'm running latest on the PR locally, first build system-test image with what I think is the latest version of core with stable/latest xdr, this is the git ref that was used for
then I run the tests:
but I'm seeing error in simulate tx web server handler in rpc server:
|
@sreuland shoot, okay. I'm not 100% sure about XDR compatibility (this thread has git refs), but the beta.5 is actually for current testnet rather than the current build 😕 I didn't realize we were updating the system tests to latest xdr also - I was just hoping to migrate them to use the stellar-sdk over soroban-client... In that case I need to push a PR that duplicates stellar/js-soroban-client#167 over to stellar-sdk, but I was hoping not to do that until we actually merged that PR... 😞 There's two options, I guess:
|
@Shaptic , what's in this pr should still be related to just enabling stellar-sdk usage in system test for any set of soroban platform component versions. Sounds like my attempt to verify these changes which use js-stellar-sdk by building and running system-test with the mainline versions was incorrect state. I let defaults kick in on the build for latest mainline versions of cli/rpc and set core =fcbbad4ce7` and js=11.0.0-beta.5. We just need to re-run system-test build from this PR with the correct/matched versions that will work with some version of js-stellar-sdk, should i build using the latest Preview 11 versions for core/rpc/cli and then what version of js-stellar-sdk works with the preview 11? currently js-soroban-client is ref'd for js in preview 11 only. |
@sreuland I think that's right, yeah: |
I think we'll need #83 to merge and pull that in here, as tests aren't able to get cli to install a contract due to that rc sdk usage on the soroban-examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solid work!
Reference: stellar/stellar-cli#1048
Pending: