Java: show the XDR source code in the javadoc #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JakeUrban, can you review the PR? |
overcat
force-pushed
the
java-source-comment
branch
2 times, most recently
from
8cc560e
to
dedb7d0
Compare
overcat
force-pushed
the
java-source-comment
branch
from
dedb7d0
to
ef2d929
Compare
leighmcculloch
approved these changes
May 15, 2024
|
Nice, thanks for fixing the comment rendering. Some day it'd be awesome if it also took the comments in the XDR and made them available to the generators for inserting into the code. So that comments on an enum value, could be rendered by a generator onto the enum written into the code. And same for struct fields, structs themselves, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the way we rendered comments prevented XDR definitions from being displayed in javadoc, in this PR we have added it.
See lightsail-network/java-stellar-sdk#595