Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade doc dependencies, including sphinx-rtd-theme 0.5.0 #1722

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

huonw
Copy link
Member

@huonw huonw commented Jun 23, 2020

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2020

Code Climate has analyzed commit ae9835a and detected 0 issues on this pull request.

View more on Code Climate.

@huonw huonw changed the title Upgrade to sphinx-rtd-theme 0.5.0 Upgrade doc dependencies, including sphinx-rtd-theme 0.5.0 Jun 24, 2020
@huonw huonw marked this pull request as ready for review June 24, 2020 03:04
@huonw huonw requested a review from timpitman June 24, 2020 03:07
Copy link
Contributor

@timpitman timpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make a point in the release checklist to address this regularly - eg just after each release (to minimise risk) we could upgrade all the doc dependencies?

@huonw
Copy link
Member Author

huonw commented Jun 25, 2020

That's a good idea! I won't add it here, though, in the interests of getting this merged now.

@huonw huonw merged commit ef5389c into develop Jun 25, 2020
@huonw huonw deleted the feature/1499-newer-theme branch June 25, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants