Fixed the bug in LinkSequence that threw an error when no link targets were given #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youph
changed the title
youph
changed the title
adocherty
suggested changes
Oct 15, 2018
…e generators with targets
|
Hi Yuri, I think we should also check the HinSAGE link generator in the same way and I've added such a test. I also looked at the node_generators and I was not testing them with targets well. I've added some tests for those as well to this PR. |
added 2 commits
October 16, 2018 11:02
…com/stellargraph/stellargraph into bugfix/link_mappers_without_targets
|
@adocherty thanks for adding the tests! |
|
@adocherty strange: I've marked your comments as resolved, but github still says I need to address the change request. Does it wait for you to mark the comments as resolved as well? |
adocherty
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkSequenceclass that occurred when no link targets were given to the link iterator.test_GraphSAGELinkGenerator_no_targets, covering the case of link generator with no targets (e.g., for prediction)