Require Python >= 3.6, since 3.5 no longer works #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1a80851 and detected 0 issues on this pull request. View more on Code Climate. |
timpitman
approved these changes
Jan 9, 2020
|
I can't see any other relevant instances of "3.5" in the repo: % git grep '3\.5' -- '*.py'
tests/utils/test_calibration.py: x_train = [[1, 1], [2, 3.5]]
tests/utils/test_calibration.py: x_train = np.array([[1, 1], [2, 3.5]])
tests/utils/test_calibration.py: x_train = np.array([1, 3.5])
tests/utils/test_calibration.py: x_train = [[1, 1], [2, 3.5]]
tests/utils/test_calibration.py: x_train = np.array([[1, 1], [2, 3.5]])So I guess the Meta section in the sidebar of pypi is populated from here automatically, however I do not know for sure. |
PantelisElinas
approved these changes
Jan 12, 2020
huonw
added a commit
that referenced
this pull request
Jan 15, 2020
Now (after #641), we only support Python 3.6 and 3.7, and so we can use newer standard library functions, like `random.choices` instead of `random.choice` in a loop. `SampledBreadthFirstWalk` is ~1.3x faster: | commit | min | max | mean | stddev | median | iqr | outliers | ops (/s) | rounds | iterations | |---------|----:|-----:|-----:|-------:|-------:|-----:|---------:|---------:|-------:|-----------:| | this PR | 373 | 1130 | 446 | 86.4 | 413 | 75.4 | 181;115 | 2241 | 1831 | 1 | | develop | 450 | 1280 | 542 | 73.0 | 525 | 68.0 | 62;20 | 1842 | 557 | 1 | `SampledHeterogeneousBreadthFirstWalk` is ~1.5x faster: | commit | min | max | mean | stddev | median | iqr | outliers | ops (/s) | rounds | iterations | |---------|----:|-----:|-----:|-------:|-------:|-----:|---------:|---------:|-------:|-----------:| | this PR | 305 | 984 | 347 | 74.4 | 312 | 42.8 | 213;229 | 2878 | 2098 | 1 | | develop | 453 | 1330 | 515 | 89.3 | 478 | 62.4 | 102;84 | 1939 | 1271 | 1 | `DirectedBreadthFirstNeighbours` is ~1.2x faster: | commit | min | max | mean | stddev | median | iqr | outliers | ops (/s) | rounds | iterations | |---------|-----:|-----:|-----:|-------:|-------:|----:|---------:|---------:|-------:|-----------:| | this PR | 1350 | 3230 | 1620 | 195 | 1610 | 231 | 174;10 | 616 | 550 | 1 | | develop | 1670 | 3370 | 2010 | 187 | 2000 | 174 | 132;19 | 495 | 465 | 1 | Times in microseconds; speed-ups estimated from median column.
timpitman
added a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #638, it was observed that stellargraph no longer supports Python 3.5, due to use of 3.6 features like f-strings.
This makes this requirement formal, in
setup.py.This may have been accidental, so maybe we want to not land this and instead fix our support for 3.5?