Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add componentShouldUpdate to stencilLifecycle declaration #18

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Add componentShouldUpdate to stencilLifecycle declaration #18

merged 1 commit into from
Oct 1, 2021

Conversation

dmartinjs
Copy link
Contributor

Fix #14

suzulabo added a commit to suzulabo/stencil-eslint that referenced this pull request Jun 28, 2021
@suzulabo
https://github.com/ionic-team/stencil-eslint/pull/18
70a1a24
rwaskiewicz
rwaskiewicz approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rwaskiewicz rwaskiewicz merged commit 43f832c into stencil-community:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaskiewicz rwaskiewicz rwaskiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not identified lifecycle 'componentShouldUpdate'
2 participants
@dmartinjs @rwaskiewicz