-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(eslint): eslint 7 upgrade #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rwaskiewicz
commented
Oct 28, 2021
README.md
Outdated
@@ -34,6 +39,16 @@ Add a new `lint` script to the `package.json`: | |||
} | |||
``` | |||
|
|||
Considering putting a note about ESLint, node_modules is ignored... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: I need to remove or commit to this
CI if failing, looks like |
update dependencies to support ESLint 7, and make v7 the earliest version that is supported by this library. update tests for rules that have fixers, but weren't being previously evaluated. this required some test cases to be updated as well as they were not being properly run previously. update readme to specify cleaner install instructions for npm 7+ users BREAKING CHANGE: ESLint version 6 and below are no longer supported
rwaskiewicz
force-pushed
the
rwaskiewicz/eslint7-support
branch
from
October 28, 2021 17:49
a908660
to
4b62529
Compare
ltm
approved these changes
Oct 29, 2021
alex-ketch
reviewed
Oct 29, 2021
Co-authored-by: Alex Ketch <alex-ketch@users.noreply.github.com>
Thanks @alex-ketch! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ESLint v7.0 is not supported by this library
Relates to #32, most of this work is derived from the original work done by the author of #32. @alex-ketch did most of the work here 🎉
GitHub Issue Number: N/A
What is the new behavior?
update dependencies to support ESLint 7, and make v7 the earliest
version that is supported by this library.
update tests for rules that have fixers, but weren't being previously
evaluated. this required some test cases to be updated as well as they
were not being properly run previously.
update readme to specify cleaner install instructions for npm 7+ users
BREAKING CHANGE: ESLint version 6 and below are no longer supported
Does this introduce a breaking change?
Applications will be required to upgrade to ESLint v7.0.0. This PR does not include support for v8.0.0 of ESLint.
Testing
npm init stencil
.}