Fix write EPIPE error #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh! Now, it's passing on Linux but failing on Mac and Windows with the original error: https://travis-ci.org/stencila/convert/jobs/537585491#L171 |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 92.47% 92.32% -0.16%
==========================================
Files 24 24
Lines 2074 2085 +11
Branches 542 547 +5
==========================================
+ Hits 1918 1925 +7
- Misses 149 153 +4
Partials 7 7
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 0.36.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was reported with respect to converting to HTML but it also occurs when converting to JSON.
$ npx ts-node --files src/cli ./tests/issues/74-write-epipe.docx --to json Error: write EPIPE at WriteWrap.afterWrite (net.js:836:14)This suggests it's a problem within
readand this issue suggest that it is a problem with use ofstdinofstdoutwithinpandoc.run.