Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates + Pandoc SoftBreak (#93) #94

Merged
merged 5 commits into from
Jun 6, 2019
Merged

Doc updates + Pandoc SoftBreak (#93) #94

merged 5 commits into from
Jun 6, 2019

Conversation

jwijay
Copy link
Contributor

@jwijay jwijay commented Jun 5, 2019

docs: Updates some outdated documentation.
fix: Resolves unhandled Pandoc SoftBreak in #93.

jwijay added 4 commits June 4, 2019 16:42
Signed-off-by: Jackie Wijaya <jackie.wijaya@gmail.com>
Signed-off-by: Jackie Wijaya <jackie.wijaya@gmail.com>
Signed-off-by: Jackie Wijaya <jackie.wijaya@gmail.com>

Signed-off-by: Jackie Wijaya <jackie.wijaya@gmail.com>
@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #94 into master will increase coverage by 2.84%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   85.88%   88.73%   +2.84%     
==========================================
  Files          30       30              
  Lines        2360     3168     +808     
  Branches      637     1016     +379     
==========================================
+ Hits         2027     2811     +784     
- Misses        326      349      +23     
- Partials        7        8       +1
Impacted Files Coverage Δ
src/gdoc.ts 84.13% <ø> (-0.67%) ⬇️
src/md.ts 96.25% <ø> (+1.18%) ⬆️
src/tdp.ts 76.02% <ø> (+4.67%) ⬆️
src/pandoc.ts 94.41% <50%> (+2.81%) ⬆️
src/jats.ts 93.33% <0%> (-6.67%) ⬇️
src/docx.ts 94.11% <0%> (-5.89%) ⬇️
src/index.ts 99.21% <0%> (-0.79%) ⬇️
src/rpng.ts 97.52% <0%> (-0.24%) ⬇️
src/yaml.ts 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19b501...ce33158. Read the comment docs.

@nokome
Copy link
Member

nokome commented Jun 6, 2019

Thanks @jwijay! I modified the code a little so that the function no longer throws and exception but instead falls back to decoding inlines to a string (as you implemented for SoftBreak)

@nokome nokome merged commit 69dc39f into master Jun 6, 2019
@nokome nokome deleted the doc-updates branch June 6, 2019 00:07
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 0.43.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants