fix(runtime): stop eager json parsing for unknown and any type bindings #6384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneK
force-pushed
the
fix/json-hydration
branch
from
6ade578 to
787f2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6368, #6380
What is the current behavior?
The issue is whenever you use Stencil with an input or textarea, Stencil tries to hydrate the value on change. So if the user inputs {}, it becomes a literal object, which we try to Stringify in Ionic Framework and it becomes [object Object].
GitHub Issue Number: #6368, #6380
What is the new behavior?
We're removing the bit that tries to imitate hydration in the HTML for any and complex types for now. In the future, this might be implemented in a more thorough way that's less likely to have impact elsewhere.
Additionally, there's regression tests to prevent this case from happening again in the future.
Documentation
Does this introduce a breaking change?
Testing
Other information