Skip to content

chore: use relative paths for improved local devx #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnjenkins wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

chore: use relative paths for improved local devx #6530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/esbuild/internal-platform-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ export async function getInternalClientBundles(opts: BuildOptions): Promise<ESBu
},
plugins: [
replace(createReplaceData(opts)),
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-globals', '@stencil/core/internal/app-globals'),
externalAlias('@app-data', '../app-data/index.js'),
externalAlias('@app-globals', '../app-globals/index.js'),
externalAlias('@utils/shadow-css', './shadow-css.js'),
findAndReplaceLoadModule(),
],
Expand Down Expand Up @@ -89,8 +89,8 @@ export async function getInternalClientBundles(opts: BuildOptions): Promise<ESBu
plugins: [
replace(createReplaceData(opts)),
externalAlias('@platform', '@stencil/core'),
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-globals', '@stencil/core/internal/app-globals'),
externalAlias('@app-data', '../app-data/index.js'),
externalAlias('@app-globals', '../app-globals/index.js'),
],
};

Expand Down
6 changes: 3 additions & 3 deletions scripts/esbuild/internal-platform-hydrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export async function getInternalPlatformHydrateBundles(opts: BuildOptions): Pro
},
plugins: [
externalAlias('@utils/shadow-css', '../client/shadow-css.js'),
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-globals', '@stencil/core/internal/app-globals'),
externalAlias('@app-data', '../app-data/index.js'),
externalAlias('@app-globals', '../app-globals/index.js'),
],
};

Expand All @@ -70,7 +70,7 @@ export async function getInternalPlatformHydrateBundles(opts: BuildOptions): Pro
},
plugins: [
externalAlias('@utils/shadow-css', '../client/shadow-css.js'),
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-data', '../app-data/index.js'),
externalAlias('@hydrate-factory', '@stencil/core/hydrate-factory'),
],
};
Expand Down
2 changes: 1 addition & 1 deletion scripts/esbuild/internal-platform-testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export async function getInternalTestingBundle(opts: BuildOptions): Promise<ESBu
external,
alias: internalTestingAliases,
plugins: [
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-data', '../app-data/index.js'),
externalAlias('@utils/shadow-css', '../client/shadow-css.js'),
],
};
Expand Down
2 changes: 1 addition & 1 deletion scripts/esbuild/testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export async function buildTesting(opts: BuildOptions) {
alias: aliases,
banner: { js: getBanner(opts, `Stencil Testing`, true) },
plugins: [
externalAlias('@app-data', '@stencil/core/internal/app-data'),
externalAlias('@app-data', '../internal/app-data/index.js'),
externalAlias('@platform', '@stencil/core/internal/testing'),
externalAlias('../internal/testing/index.js', '@stencil/core/internal/testing'),
externalAlias('@stencil/core/dev-server', '../dev-server/index.js'),
Expand Down
Loading