Implemented parsing of range literals #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
reviewed
Apr 5, 2018
Tests/StencilTests/ForNodeSpec.swift
Outdated
| @@ -173,7 +173,7 @@ func testForNode() { | |||
| .block(value: "for i"), | |||
| ] | |||
| let parser = TokenParser(tokens: tokens, environment: Environment()) | |||
| let error = TemplateSyntaxError("'for' statements should use the following 'for x in y where condition' `for i`.") | |||
| let error = TemplateSyntaxError("'for' statements should use the following syntax:\n`for x in y where condition`") | |||
There was a problem hiding this comment.
TemplateSyntaxError message is expected to be a single line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative implementation of #179 that does not introduce new syntax for loops and automatically supports if-in expressions.
If we merge #175 we could even support open ranges, but for now only closed ranges are supported.
Closes #179
Closes SwiftGen/StencilSwiftKit#74