Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for property via selector before using value(forKey:) #234

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Conversation

ilyapuchka
Copy link
Collaborator

Resolves #231

@djbe
Copy link
Contributor

djbe commented Sep 11, 2018

Ideally we'd be able to log some sort of warning instead of silently continuing. More often than not, I prefer the compiler/runtime to tell me if I did something wrong instead of just doing it's own thing.

What's the general consensus on this? Error out (current behaviour), or silently continue? @AliSoftware @kylef @yonaskolb

@ilyapuchka
Copy link
Collaborator Author

This is consistent with current behavior for undefined properties. If we want to revisit it, which I agree we, I think better to do it separately.

Copy link
Contributor

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's current behaviour, then it's good for me.

@djbe djbe merged commit 831cdf5 into master Sep 11, 2018
@djbe djbe deleted the check-kvo branch September 11, 2018 21:59
@mbrandonw
Copy link

Thanks for taking care of that so quickly @ilyapuchka!

@djbe djbe added this to the 0.13.0 milestone Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants