[dockers] save extension dockers with an image tag #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
approved these changes
Nov 25, 2022
stepanblyschak
pushed a commit
that referenced
this pull request
Feb 13, 2023
[sonic-linkmgrd][202012] submodule update 0839af2 Longxiang Lyu Wed Jun 15 08:46:21 2022 +0800 [202012] Fix IP header checksum in handleSendSwitchCommand (#89) afc4972 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (#23)" (#85) ed52d0a Longxiang Lyu Tue May 31 10:28:30 2022 +0800 Add a command line option to store logs into a separate file (#83) sign-off: Jing Zhang zhangjing@microsoft.com
stepanblyschak
pushed a commit
that referenced
this pull request
Nov 21, 2023
…utomatically (sonic-net#17174) #### Why I did it src/sonic-host-services ``` * 586b1e9 - (HEAD -> master, origin/master, origin/HEAD) Disable systemd auto-restart of dependent services for spineRouters (#83) (5 hours ago) [Deepak Singhal] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
When build SONiC dockers, SONiC build system tags all of them with
latesttag. This is Ok for all built-in dockers because we will also tag them with image version tag insonic_debian_extension.j2script. On the other hand, some of these dockers are SONiC packages and they are installed bysonic-package-managerwhich creates a only one tag whcih is recorded in the corresponding .gz file. This leads to having these dockers tagged only withlatesttag. This change saves the tag as an image version string in .gz file, so that these dockers have version identification in their tag.How I did it
I modified slave.mk to save the version tag instead of latest tag.
How to verify it
I verified this change by running
show version:Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)