Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking callbacks and fix tracing::Span leak #53

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

emgre
Copy link
Contributor

@emgre emgre commented Nov 1, 2021

  • Fix client callbacks using tokio::runtime::block_on. They now span a task instead. oo-bindgen was also updated to execute async responses in .NET threads, not Rust threads. See stepfunc/oo_bindgen@5e95cf0
  • Fix leak of tracing::Span due to missing impl.

@emgre emgre force-pushed the bugfix/bindings branch 2 times, most recently from 9b467f9 to c22e96b Compare November 1, 2021 20:40
@emgre emgre merged commit 5537537 into master Nov 1, 2021
@jadamcrain jadamcrain deleted the bugfix/bindings branch November 20, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant