Skip to content

Commit

Permalink
update for run.javac testing:
Browse files Browse the repository at this point in the history
+ https://bugs.openjdk.org/browse/JDK-8341408 has been resolved
  Since preview features can be tested only against latest
  there is no use in keeping Excuse JavacBug8341408 => remove
  • Loading branch information
stephan-herrmann committed Dec 3, 2024
1 parent 04ec289 commit 6098a84
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1151,9 +1151,7 @@ Excuse excuseFor(JavacCompiler compiler) {
JavacBug8337980 = // https://bugs.openjdk.org/browse/JDK-8337980
new JavacHasABug(MismatchType.EclipseErrorsJavacNone /* add pivot JDK24 */),
JavacBug8343306 = // https://bugs.openjdk.org/browse/JDK-8343306
new JavacHasABug(MismatchType.EclipseErrorsJavacNone /* add pivot JDK24 */),
JavacBug8341408 = // https://bugs.openjdk.org/browse/JDK-8341408
new JavacBug8341408();
new JavacHasABug(MismatchType.EclipseErrorsJavacNone /* add pivot JDK24 */);

// bugs that have been fixed but that we've not identified
public static JavacHasABug
Expand Down Expand Up @@ -1247,7 +1245,7 @@ String getCompilerOptions() {
}
public static class JavacBug8341408 extends JavacBugExtraJavacOptionsPlusMismatch {
public JavacBug8341408() {
super("--enable-preview -source 23 -Xlint:-preview", MismatchType.StandardOutputMismatch);
super("--enable-preview -source 24 -Xlint:-preview", MismatchType.StandardOutputMismatch);
// FIXME this.pivotCompliance = ClassFileConstants.JDK24;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import java.util.Map;
import junit.framework.Test;
import org.eclipse.jdt.core.tests.compiler.regression.AbstractRegressionTest.JavacTestOptions.JavacHasABug;
import org.eclipse.jdt.internal.compiler.batch.FileSystem;
import org.eclipse.jdt.internal.compiler.env.INameEnvironment;
import org.eclipse.jdt.internal.compiler.impl.CompilerOptions;
Expand Down Expand Up @@ -1598,7 +1597,7 @@ public class X {
}
}
""");
runConformTest(new String[] {"X.java", clazz.toString()}, expectedOuts, getCompilerOptions(true), VMARGS, JavacHasABug.JavacBug8341408);
runConformTest(new String[] {"X.java", clazz.toString()}, expectedOuts);
}
public void testInstanceof_widenUnbox_Byte() {
testInstanceof_widenUnbox("Byte", 1, "49+49|49+49|49+49|49.0+49.0|49.0+49.0|");
Expand Down

0 comments on commit 6098a84

Please sign in to comment.