Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modbus default port is 502 #771

Closed
wants to merge 6 commits into from
Closed

Conversation

kay30kim
Copy link

The system was previously configured to use port 1502 as a hard-coded value. However, I recommend updating this to port 502, which is the standard default port for Modbus communication, as specified by industry guidelines.

For further reference, please see Cisco's Modbus configuration documentation:
https://www.cisco.com/c/en/us/td/docs/switches/connectedgrid/cgs2520/software/release/12_2_53_ex/configuration/guide/scg2520/swmodbus.pdf

Copy link

cla-bot bot commented Sep 27, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link
Contributor

@mhei mhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the part which changes the documentation, but leave alone the test stuff. Port 502 is a privileged one on Linux systems, that means that only root can bind to it. So this would prevent usual users to run the tests without using sudo or other means.

@kay30kim
Copy link
Author

kay30kim commented Sep 29, 2024 via email

Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link

cla-bot bot commented Oct 2, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Copy link

cla-bot bot commented Oct 3, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

@mhei
Copy link
Contributor

mhei commented Oct 6, 2024

Kay, I think you mix two different tasks here:
This PR initially suggested to rewrite code in this libmodbus repo. The proposed change in the documentation is reasonable and should be merged. Please update this PR in that you put a single commit in this existing branch which does exactly the mentioned change. Not more - not less. Then this PR can be merged after all formal issues are solved (CLA signed, commits with SoB, proper patch description etc.). I really encourage to go forward here.

The other point/task is your own PV inverter application. It just uses libmodbus. But it should not be part of this repo. I recommend to share it in a dedicated repo here on Github. This design keeps a clear barrier between library and application code. Please consider moving on this way.

@stephane stephane closed this in 6a39116 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants