-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modbus default port is 502 #771
Conversation
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the part which changes the documentation, but leave alone the test stuff. Port 502 is a privileged one on Linux systems, that means that only root can bind to it. So this would prevent usual users to run the tests without using sudo or other means.
Hi Stephane,
Thank you for replying so quickly.
I really appreciate it and understand the reason why the test uses 1502
port..! Yeah it is reasonable !
I’m making PV Invertor charger and sub-station(metering PV Invertor) using
Modbus unit-server-test.c file..! I hope to contribute my code after I
finish to implement this!
Thank you.
Have a nice weekend.
Best Regards,
Kay
…On Sat, Sep 28, 2024 at 2:23 AM Michael Heimpold ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'm fine with the part which changes the documentation, but leave alone
the test stuff. Port 502 is a privileged one on Linux systems, that means
that only root can bind to it. So this would prevent usual users to run the
tests without using sudo or other means.
—
Reply to this email directly, view it on GitHub
<#771 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOFH2EE2TFDCNCP3AYEVBCLZYZYRJAVCNFSM6AAAAABO7ZZMZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZUHE3TKNBYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
…n can write register
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
…onnection from outside device
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Kay, I think you mix two different tasks here: The other point/task is your own PV inverter application. It just uses libmodbus. But it should not be part of this repo. I recommend to share it in a dedicated repo here on Github. This design keeps a clear barrier between library and application code. Please consider moving on this way. |
The system was previously configured to use port 1502 as a hard-coded value. However, I recommend updating this to port 502, which is the standard default port for Modbus communication, as specified by industry guidelines.
For further reference, please see Cisco's Modbus configuration documentation:
https://www.cisco.com/c/en/us/td/docs/switches/connectedgrid/cgs2520/software/release/12_2_53_ex/configuration/guide/scg2520/swmodbus.pdf