Skip to content
This repository has been archived by the owner on Jan 14, 2018. It is now read-only.

Logging fixes #404

Open
wants to merge 4 commits into
base: release
Choose a base branch
from
Open

Conversation

seva-ask
Copy link
Contributor

@seva-ask seva-ask commented Feb 9, 2015

Hello!
This pull request is fix of #403
When toString methods of some objects are expensive, we should be able to disable calling them in logging by changing log level. But when we use string concatenation, they will be called independently of log level. So let's use formatted version of logging. I have changed all logging calls that I have found.
Fox example, it is very actual for protobuf classes, because toString methods of them are overrided to write down all fields.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant